Commit 6da8344f authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Paolo Abeni
Browse files

eth: fbnic: report FW uptime in health diagnose 



FW crashes are detected based on uptime going back, expose the uptime
via devlink health diagnose.

 $ devlink -j health diagnose pci/0000:01:00.0 reporter fw
 {"last_heartbeat":{"fw_uptime":{"sec":201,"msec":76}}}
 $ devlink -j health diagnose pci/0000:01:00.0 reporter fw
 last_heartbeat:
    fw_uptime:
      sec: 201 msec: 76

Reviewed-by: default avatarLee Trager <lee@trager.us>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250916231420.1693955-9-kuba@kernel.org


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 005a5472

Documentation/networking/device_drivers/ethernet/meta/fbnic.rst

+3 −1
Original line number Diff line number Diff line
@@ -77,7 +77,9 @@ fw reporter 


The ``fw`` health reporter tracks FW crashes. Dumping the reporter will

show the core dump of the most recent FW crash, and if no FW crash has

happened since power cycle - a snapshot of the FW memory.

happened since power cycle - a snapshot of the FW memory. Diagnose callback

shows FW uptime based on the most recently received heartbeat message

(the crashes are detected by checking if uptime goes down).



Statistics

----------

drivers/net/ethernet/meta/fbnic/fbnic_devlink.c

+29 −0
Original line number Diff line number Diff line
@@ -485,6 +485,34 @@ static int fbnic_fw_reporter_dump(struct devlink_health_reporter *reporter, 
	return err;

}



static int

fbnic_fw_reporter_diagnose(struct devlink_health_reporter *reporter,

			   struct devlink_fmsg *fmsg,

			   struct netlink_ext_ack *extack)

{

	struct fbnic_dev *fbd = devlink_health_reporter_priv(reporter);

	u32 sec, msec;



	/* Device is most likely down, we're not exchanging heartbeats */

	if (!fbd->prev_firmware_time)

		return 0;



	sec = div_u64_rem(fbd->firmware_time, MSEC_PER_SEC, &msec);



	devlink_fmsg_pair_nest_start(fmsg, "last_heartbeat");

	devlink_fmsg_obj_nest_start(fmsg);

	devlink_fmsg_pair_nest_start(fmsg, "fw_uptime");

	devlink_fmsg_obj_nest_start(fmsg);

	devlink_fmsg_u32_pair_put(fmsg, "sec", sec);

	devlink_fmsg_u32_pair_put(fmsg, "msec", msec);

	devlink_fmsg_obj_nest_end(fmsg);

	devlink_fmsg_pair_nest_end(fmsg);

	devlink_fmsg_obj_nest_end(fmsg);

	devlink_fmsg_pair_nest_end(fmsg);



	return 0;

}



void __printf(2, 3)

fbnic_devlink_fw_report(struct fbnic_dev *fbd, const char *format, ...)

{
@@ -503,6 +531,7 @@ fbnic_devlink_fw_report(struct fbnic_dev *fbd, const char *format, ...) 
static const struct devlink_health_reporter_ops fbnic_fw_ops = {

	.name = "fw",

	.dump = fbnic_fw_reporter_dump,

	.diagnose = fbnic_fw_reporter_diagnose,

};



int fbnic_devlink_health_create(struct fbnic_dev *fbd)