Commit 6dfcbd7d authored by Zqiang's avatar Zqiang Committed by Jakub Kicinski
Browse files

net: usb: enable the work after stop usbnet by ip down/up 



Oleksij reported that:
The smsc95xx driver fails after one down/up cycle, like this:
 $ nmcli device set enu1u1 managed no
 $ p a a 10.10.10.1/24 dev enu1u1
 $ ping -c 4 10.10.10.3
 $ ip l s dev enu1u1 down
 $ ip l s dev enu1u1 up
 $ ping -c 4 10.10.10.3
The second ping does not reach the host. Networking also fails on other interfaces.

Enable the work by replacing the disable_work_sync() with cancel_work_sync().

[Jun Miao: completely write the commit changelog]

Fixes: 2c04d279 ("net: usb: Convert tasklet API to new bottom half workqueue mechanism")
Reported-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Tested-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: default avatarZqiang <qiang.zhang@linux.dev>
Signed-off-by: default avatarJun Miao <jun.miao@intel.com>
Link: https://patch.msgid.link/20250708081653.307815-1-jun.miao@intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3b932976

drivers/net/usb/usbnet.c

+2 −2
Original line number Diff line number Diff line
@@ -861,14 +861,14 @@ int usbnet_stop (struct net_device *net) 
	/* deferred work (timer, softirq, task) must also stop */

	dev->flags = 0;

	timer_delete_sync(&dev->delay);

	disable_work_sync(&dev->bh_work);

	cancel_work_sync(&dev->bh_work);

	cancel_work_sync(&dev->kevent);



	/* We have cyclic dependencies. Those calls are needed

	 * to break a cycle. We cannot fall into the gaps because

	 * we have a flag

	 */

	disable_work_sync(&dev->bh_work);

	cancel_work_sync(&dev->bh_work);

	timer_delete_sync(&dev->delay);

	cancel_work_sync(&dev->kevent);