Commit 6e3b7e86 authored by Conor Dooley's avatar Conor Dooley
Browse files

firmware: microchip: don't unconditionally print validation success 



If validation fails, both prints are made. Skip the success one in the
failure case.

Fixes: ec5b0f11 ("firmware: microchip: add PolarFire SoC Auto Update support")
Signed-off-by: default avatarConor Dooley <conor.dooley@microchip.com>
parent 6b0856ee

drivers/firmware/microchip/mpfs-auto-update.c

+2 −0
Original line number Diff line number Diff line
@@ -206,10 +206,12 @@ static int mpfs_auto_update_verify_image(struct fw_upload *fw_uploader) 
	if (ret | response->resp_status) {

		dev_warn(priv->dev, "Verification of Upgrade Image failed!\n");

		ret = ret ? ret : -EBADMSG;

		goto free_message;

	}



	dev_info(priv->dev, "Verification of Upgrade Image passed!\n");



free_message:

	devm_kfree(priv->dev, message);

free_response:

	devm_kfree(priv->dev, response);