Commit 6f769f22 authored by David Howells's avatar David Howells Committed by David S. Miller
Browse files

rxrpc: Fix response to PING RESPONSE ACKs to a dead call 



Stop rxrpc from sending a DUP ACK in response to a PING RESPONSE ACK on a
dead call.  We may have initiated the ping but the call may have beaten the
response to completion.

Fixes: 18bfeba5 ("rxrpc: Perform terminal call ACK/ABORT retransmission from conn processor")
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: "David S. Miller" <davem@davemloft.net>
cc: Eric Dumazet <edumazet@google.com>
cc: Jakub Kicinski <kuba@kernel.org>
cc: Paolo Abeni <pabeni@redhat.com>
cc: linux-afs@lists.infradead.org
cc: netdev@vger.kernel.org
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e7870cf1

net/rxrpc/conn_event.c

+8 −0
Original line number Diff line number Diff line
@@ -95,6 +95,14 @@ void rxrpc_conn_retransmit_call(struct rxrpc_connection *conn, 


	_enter("%d", conn->debug_id);



	if (sp && sp->hdr.type == RXRPC_PACKET_TYPE_ACK) {

		if (skb_copy_bits(skb, sizeof(struct rxrpc_wire_header),

				  &pkt.ack, sizeof(pkt.ack)) < 0)

			return;

		if (pkt.ack.reason == RXRPC_ACK_PING_RESPONSE)

			return;

	}



	chan = &conn->channels[channel];



	/* If the last call got moved on whilst we were waiting to run, just