Commit 6f880e7b authored by Peng Fan's avatar Peng Fan Committed by Mathieu Poirier
Browse files

remoteproc: imx_dsp_rproc: Simplify start/stop error handling 



Replace goto-based error handling with early return pattern in
imx_dsp_rproc_{start,stop}() functions, and simplify if-else logic.

No functional changes, only code structure improvements for better
maintainability.

Signed-off-by: default avatarPeng Fan <peng.fan@nxp.com>
Reviewed-by: default avatarDaniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20251119-imx-dsp-2025-11-19-v4-12-adafd342d07b@nxp.com


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 5c33a631

drivers/remoteproc/imx_dsp_rproc.c

+18 −21
Original line number Diff line number Diff line
@@ -376,20 +376,19 @@ static int imx_dsp_rproc_start(struct rproc *rproc) 
	struct device *dev = rproc->dev.parent;

	int ret;



	if (dcfg->ops && dcfg->ops->start) {

		ret = dcfg->ops->start(rproc);

		goto start_ret;

	}



	if (!dcfg->ops || !dcfg->ops->start)

		return -EOPNOTSUPP;



start_ret:

	if (ret)

	ret = dcfg->ops->start(rproc);

	if (ret) {

		dev_err(dev, "Failed to enable remote core!\n");

	else if (priv->flags & WAIT_FW_READY)

		return ret;

	}



	if (priv->flags & WAIT_FW_READY)

		return imx_dsp_rproc_ready(rproc);



	return ret;

	return 0;

}



static int imx_dsp_rproc_mmio_stop(struct rproc *rproc)
@@ -431,20 +430,18 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) 
		return 0;

	}



	if (dcfg->ops && dcfg->ops->stop) {

		ret = dcfg->ops->stop(rproc);

		goto stop_ret;

	}



	if (!dcfg->ops || !dcfg->ops->stop)

		return -EOPNOTSUPP;



stop_ret:

	if (ret)

	ret = dcfg->ops->stop(rproc);

	if (ret) {

		dev_err(dev, "Failed to stop remote core\n");

	else

		return ret;

	}



	priv->flags &= ~REMOTE_IS_READY;



	return ret;

	return 0;

}



/**