Commit 6fa02208 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: phy: aquantia: remove handling for get_rate_matching(PHY_INTERFACE_MODE_NA) 



After commit 7642cc28 ("net: phylink: fix PHY validation with rate
adaption"), the API contract changed and PHY drivers are no longer
required to respond to the .get_rate_matching() method for
PHY_INTERFACE_MODE_NA. This was later followed up by documentation
commit 6d4cfcf9 ("net: phy: Update documentation for
get_rate_matching").

As such, handling PHY_INTERFACE_MODE_NA in the Aquantia PHY driver
implementation of this method is unnecessary and confusing. Remove it.

Cc: Sean Anderson <sean.anderson@seco.com>
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250821152022.1065237-8-vladimir.oltean@nxp.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 08048ba4

drivers/net/phy/aquantia/aquantia_main.c

+1 −2
Original line number Diff line number Diff line
@@ -1067,8 +1067,7 @@ static int aqr_gen2_get_rate_matching(struct phy_device *phydev, 
				      phy_interface_t iface)

{

	if (iface == PHY_INTERFACE_MODE_10GBASER ||

	    iface == PHY_INTERFACE_MODE_2500BASEX ||

	    iface == PHY_INTERFACE_MODE_NA)

	    iface == PHY_INTERFACE_MODE_2500BASEX)

		return RATE_MATCH_PAUSE;

	return RATE_MATCH_NONE;

}