Unverified Commit 6ffdc7eb authored by Marek Vasut's avatar Marek Vasut Committed by Mark Brown
Browse files

regcache: Demote defaults readback from HW to debug print 



Since commit 632e0473 ("clk: rs9: Fix suspend/resume"), the
clk-renesas-pcie-9series driver produces the following print in
kernel log on boot:
"
clk-renesas-pcie-9series 8-0068: No cache defaults, reading back from HW
"
This is caused by the presence of .num_reg_defaults_raw in its struct
regmap_config, without a matching .reg_defaults_raw table of built-in
register default values.

This configuration is valid, and causes the regcache code to read the
default register settings from the hardware, which is a valid behavior
for this particular chip. In fact, this configuration is more common
than configuration with .reg_defaults_raw built-in register defaults.

Do not warn about the read of default values being read from hardware,
as that is too strong and seems unnecessary, turn the warning into a
debug print.

Suggested-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarMarek Vasut <marek.vasut+renesas@mailbox.org>
Link: https://patch.msgid.link/20260121234309.178391-1-marek.vasut+renesas@mailbox.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent dccc66b0

drivers/base/regmap/regcache.c

+1 −1
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ static int regcache_hw_init(struct regmap *map) 


	if (!map->reg_defaults_raw) {

		bool cache_bypass = map->cache_bypass;

		dev_warn(map->dev, "No cache defaults, reading back from HW\n");

		dev_dbg(map->dev, "No cache defaults, reading back from HW\n");



		/* Bypass the cache access till data read from HW */

		map->cache_bypass = true;