Unverified Commit 70d3c92d authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Robert Foss
Browse files

drm/bridge: tc358767: Use devm_clk_get_enabled() helper 



The devm_clk_get_enabled() helper:
   - calls devm_clk_get()
   - calls clk_prepare_enable() and registers what is needed in order to
     call clk_disable_unprepare() when needed, as a managed resource.

This simplifies the code and avoids the need of a dedicated function used
with devm_add_action_or_reset().

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/208a15ce4e01973daf039ad7bc0f9241f650b3af.1672415956.git.christophe.jaillet@wanadoo.fr
parent 3b85641a

drivers/gpu/drm/bridge/tc358767.c

+4 −21
Original line number Diff line number Diff line
@@ -2215,13 +2215,6 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc) 
	return -EINVAL;

}



static void tc_clk_disable(void *data)

{

	struct clk *refclk = data;



	clk_disable_unprepare(refclk);

}



static int tc_probe(struct i2c_client *client)

{

	struct device *dev = &client->dev;
@@ -2238,20 +2231,10 @@ static int tc_probe(struct i2c_client *client) 
	if (ret)

		return ret;



	tc->refclk = devm_clk_get(dev, "ref");

	if (IS_ERR(tc->refclk)) {

		ret = PTR_ERR(tc->refclk);

		dev_err(dev, "Failed to get refclk: %d\n", ret);

		return ret;

	}



	ret = clk_prepare_enable(tc->refclk);

	if (ret)

		return ret;



	ret = devm_add_action_or_reset(dev, tc_clk_disable, tc->refclk);

	if (ret)

		return ret;

	tc->refclk = devm_clk_get_enabled(dev, "ref");

	if (IS_ERR(tc->refclk))

		return dev_err_probe(dev, PTR_ERR(tc->refclk),

				     "Failed to get and enable the ref clk\n");



	/* tRSTW = 100 cycles , at 13 MHz that is ~7.69 us */

	usleep_range(10, 15);