Commit 70d81f25 authored by Maher Sanalla's avatar Maher Sanalla Committed by Jakub Kicinski
Browse files

net/mlxfw: Drop hard coded max FW flash image size 



Currently, mlxfw kernel module limits FW flash image size to be
10MB at most, preventing the ability to burn recent BlueField-3
FW that exceeds the said size limit.

Thus, drop the hard coded limit. Instead, rely on FW's
max_component_size threshold that is reported in MCQI register
as the size limit for FW image.

Fixes: 410ed13c ("Add the mlxfw module for Mellanox firmware flash process")
Signed-off-by: default avatarMaher Sanalla <msanalla@nvidia.com>
Signed-off-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Tested-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/1737030796-1441634-1-git-send-email-moshe@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d1f9f79f

drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c

+0 −2
Original line number Diff line number Diff line
@@ -14,7 +14,6 @@ 
#define MLXFW_FSM_STATE_WAIT_TIMEOUT_MS 30000

#define MLXFW_FSM_STATE_WAIT_ROUNDS \

	(MLXFW_FSM_STATE_WAIT_TIMEOUT_MS / MLXFW_FSM_STATE_WAIT_CYCLE_MS)

#define MLXFW_FSM_MAX_COMPONENT_SIZE (10 * (1 << 20))



static const int mlxfw_fsm_state_errno[] = {

	[MLXFW_FSM_STATE_ERR_ERROR] = -EIO,
@@ -229,7 +228,6 @@ static int mlxfw_flash_component(struct mlxfw_dev *mlxfw_dev, 
		return err;

	}



	comp_max_size = min_t(u32, comp_max_size, MLXFW_FSM_MAX_COMPONENT_SIZE);

	if (comp->data_size > comp_max_size) {

		MLXFW_ERR_MSG(mlxfw_dev, extack,

			      "Component size is bigger than limit", -EINVAL);