Commit 7118f56e authored by Pedro Tammela's avatar Pedro Tammela Committed by Paolo Abeni
Browse files

net/sched: sch_htb: warn about class in use while deleting 



Add extack to warn that delete was rejected because
the class is still in use

Acked-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarPedro Tammela <pctammela@mojatatu.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 8e4553ef

net/sched/sch_htb.c

+3 −1
Original line number Diff line number Diff line
@@ -1709,8 +1709,10 @@ static int htb_delete(struct Qdisc *sch, unsigned long arg, 
	 * tc subsys guarantee us that in htb_destroy it holds no class

	 * refs so that we can remove children safely there ?

	 */

	if (cl->children || qdisc_class_in_use(&cl->common))

	if (cl->children || qdisc_class_in_use(&cl->common)) {

		NL_SET_ERR_MSG(extack, "HTB class in use");

		return -EBUSY;

	}



	if (!cl->level && htb_parent_last_child(cl))

		last_child = 1;