Commit 712a92a4 authored by Kory Maincent's avatar Kory Maincent Committed by Vinod Koul
Browse files

dmaengine: dw-edma: HDMA: Add sync read before starting the DMA transfer in remote setup 



The Linked list element and pointer are not stored in the same memory as
the HDMA controller register. If the doorbell register is toggled before
the full write of the linked list a race condition error will occur.
In remote setup we can only use a readl to the memory to assure the full
write has occurred.

Fixes: e74c3957 ("dmaengine: dw-edma: Add support for native HDMA")
Reviewed-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarKory Maincent <kory.maincent@bootlin.com>
Link: https://lore.kernel.org/r/20240129-b4-feature_hdma_mainline-v7-5-8e8c1acb7a46@bootlin.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent e2f6a578

drivers/dma/dw-edma/dw-hdma-v0-core.c

+17 −0
Original line number Diff line number Diff line
@@ -222,6 +222,20 @@ static void dw_hdma_v0_core_write_chunk(struct dw_edma_chunk *chunk) 
	dw_hdma_v0_write_ll_link(chunk, i, control, chunk->ll_region.paddr);

}



static void dw_hdma_v0_sync_ll_data(struct dw_edma_chunk *chunk)

{

	/*

	 * In case of remote HDMA engine setup, the DW PCIe RP/EP internal

	 * configuration registers and application memory are normally accessed

	 * over different buses. Ensure LL-data reaches the memory before the

	 * doorbell register is toggled by issuing the dummy-read from the remote

	 * LL memory in a hope that the MRd TLP will return only after the

	 * last MWr TLP is completed

	 */

	if (!(chunk->chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL))

		readl(chunk->ll_region.vaddr.io);

}



static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first)

{

	struct dw_edma_chan *chan = chunk->chan;
@@ -252,6 +266,9 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) 
	/* Set consumer cycle */

	SET_CH_32(dw, chan->dir, chan->id, cycle_sync,

		  HDMA_V0_CONSUMER_CYCLE_STAT | HDMA_V0_CONSUMER_CYCLE_BIT);



	dw_hdma_v0_sync_ll_data(chunk);



	/* Doorbell */

	SET_CH_32(dw, chan->dir, chan->id, doorbell, HDMA_V0_DOORBELL_START);

}