Commit 71f592d2 authored by Wolfram Sang's avatar Wolfram Sang Committed by Greg Kroah-Hartman
Browse files

misc: apds990x: use 'time_left' variable with wait_event_interruptible_timeout() 



There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_event_interruptible_timeout() causing patterns like:

	timeout = wait_event_interruptible_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240604212240.4529-2-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 36c55ce8

drivers/misc/apds990x.c

+5 −5
Original line number Diff line number Diff line
@@ -625,15 +625,15 @@ static ssize_t apds990x_lux_show(struct device *dev, 
	struct apds990x_chip *chip = dev_get_drvdata(dev);

	ssize_t ret;

	u32 result;

	long timeout;

	long time_left;



	if (pm_runtime_suspended(dev))

		return -EIO;



	timeout = wait_event_interruptible_timeout(chip->wait,

	time_left = wait_event_interruptible_timeout(chip->wait,

						     !chip->lux_wait_fresh_res,

						     msecs_to_jiffies(APDS_TIMEOUT));

	if (!timeout)

	if (!time_left)

		return -EIO;



	mutex_lock(&chip->mutex);