Unverified Commit 72151ad0 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

ASoC: codecs: wsa-macro: fix uninitialized stack variables with name prefix 



Driver compares widget name in wsa_macro_spk_boost_event() widget event
callback, however it does not handle component's name prefix.  This
leads to using uninitialized stack variables as registers and register
values.  Handle gracefully such case.

Fixes: 2c4066e5 ("ASoC: codecs: lpass-wsa-macro: add dapm widgets and route")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20231003155422.801160-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 528a4a0b

sound/soc/codecs/lpass-wsa-macro.c

+3 −0
Original line number Diff line number Diff line
@@ -1685,6 +1685,9 @@ static int wsa_macro_spk_boost_event(struct snd_soc_dapm_widget *w, 
		boost_path_cfg1 = CDC_WSA_RX1_RX_PATH_CFG1;

		reg = CDC_WSA_RX1_RX_PATH_CTL;

		reg_mix = CDC_WSA_RX1_RX_PATH_MIX_CTL;

	} else {

		dev_warn(component->dev, "Incorrect widget name in the driver\n");

		return -EINVAL;

	}



	switch (event) {