Commit 72d1c182 authored by Zijun Hu's avatar Zijun Hu Committed by Rob Herring (Arm)
Browse files

of: Do not expose of_alias_scan() and correct its comments 



of_alias_scan() has no external callers and returns void.
Do not expose it and delete return value descriptions in its comments.

Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20250114-of_core_fix-v5-1-b8bafd00a86f@quicinc.com


Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
parent 1b093633

drivers/of/base.c

+1 −2
Original line number Diff line number Diff line
@@ -1812,8 +1812,7 @@ static void of_alias_add(struct alias_prop *ap, struct device_node *np, 
 *		for storing the resulting tree

 *

 * The function scans all the properties of the 'aliases' node and populates

 * the global lookup table with the properties.  It returns the

 * number of alias properties found, or an error code in case of failure.

 * the global lookup table with the properties.

 */

void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align))

{

drivers/of/of_private.h

+2 −0
Original line number Diff line number Diff line
@@ -119,6 +119,8 @@ extern void *__unflatten_device_tree(const void *blob, 
			      void *(*dt_alloc)(u64 size, u64 align),

			      bool detached);



void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align));



/**

 * General utilities for working with live trees.

 *

drivers/of/pdt.c

+2 −0
Original line number Diff line number Diff line
@@ -19,6 +19,8 @@ 
#include <linux/of.h>

#include <linux/of_pdt.h>



#include "of_private.h"



static struct of_pdt_ops *of_pdt_prom_ops __initdata;



#if defined(CONFIG_SPARC)

include/linux/of.h

+0 −1
Original line number Diff line number Diff line
@@ -398,7 +398,6 @@ extern int of_phandle_iterator_args(struct of_phandle_iterator *it, 
				    uint32_t *args,

				    int size);



extern void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align));

extern int of_alias_get_id(const struct device_node *np, const char *stem);

extern int of_alias_get_highest_id(const char *stem);