Commit 72dae6ad authored by Sreedevi Joshi's avatar Sreedevi Joshi Committed by Tony Nguyen
Browse files

idpf: update idpf_up_complete() return type to void 



idpf_up_complete() function always returns 0 and no callers use this return
value. Although idpf_vport_open() checks the return value, it only handles
error cases which never occur. Change the return type to void to simplify
the code.

Signed-off-by: default avatarSreedevi Joshi <sreedevi.joshi@intel.com>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent ee13aa1a

drivers/net/ethernet/intel/idpf/idpf_lib.c

+2 −11
Original line number Diff line number Diff line
@@ -1429,10 +1429,8 @@ static int idpf_set_real_num_queues(struct idpf_vport *vport) 
/**

 * idpf_up_complete - Complete interface up sequence

 * @vport: virtual port structure

 *

 * Returns 0 on success, negative on failure.

 */

static int idpf_up_complete(struct idpf_vport *vport)

static void idpf_up_complete(struct idpf_vport *vport)

{

	struct idpf_netdev_priv *np = netdev_priv(vport->netdev);
@@ -1442,8 +1440,6 @@ static int idpf_up_complete(struct idpf_vport *vport) 
	}



	set_bit(IDPF_VPORT_UP, np->state);



	return 0;

}



/**
@@ -1584,12 +1580,7 @@ static int idpf_vport_open(struct idpf_vport *vport, bool rtnl) 
		goto disable_vport;

	}



	err = idpf_up_complete(vport);

	if (err) {

		dev_err(&adapter->pdev->dev, "Failed to complete interface up for vport %u: %d\n",

			vport->vport_id, err);

		goto disable_vport;

	}

	idpf_up_complete(vport);



	if (rtnl)

		rtnl_unlock();