Commit 73070466 authored by Ingo Molnar's avatar Ingo Molnar
Browse files

objtool: Use O_CREAT with explicit mode mask 



Recent Ubuntu enforces 3-argument open() with O_CREAT:

      CC      /home/mingo/tip/tools/objtool/builtin-check.o
    In file included from /usr/include/fcntl.h:341,
                     from builtin-check.c:9:
    In function ‘open’,
        inlined from ‘copy_file’ at builtin-check.c:201:11:
    /usr/include/x86_64-linux-gnu/bits/fcntl2.h:52:11: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments
       52 |           __open_missing_mode ();
          |           ^~~~~~~~~~~~~~~~~~~~~~

Use 0400 as the most restrictive mode for the new file.

Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org
parent 36799069

tools/objtool/builtin-check.c

+1 −1
Original line number Diff line number Diff line
@@ -198,7 +198,7 @@ static int copy_file(const char *src, const char *dst) 
		return 1;

	}



	dst_fd = open(dst, O_WRONLY | O_CREAT | O_TRUNC);

	dst_fd = open(dst, O_WRONLY | O_CREAT | O_TRUNC, 0400);

	if (dst_fd == -1) {

		ERROR("can't open '%s' for writing", dst);

		return 1;