Commit 7314166e authored by Thorsten Blum's avatar Thorsten Blum Committed by Miklos Szeredi
Browse files

ovl: Replace offsetof() with struct_size() in ovl_stack_free() 



Compared to offsetof(), struct_size() provides additional compile-time
checks for structs with flexible arrays (e.g., __must_be_array()).

No functional changes intended.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 5aaf6a8c

fs/overlayfs/util.c

+3 −2
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ 
#include <linux/uuid.h>

#include <linux/namei.h>

#include <linux/ratelimit.h>

#include <linux/overflow.h>

#include "overlayfs.h"



/* Get write access to upper mnt - may fail if upper sb was remounted ro */
@@ -145,9 +146,9 @@ void ovl_stack_free(struct ovl_path *stack, unsigned int n) 


struct ovl_entry *ovl_alloc_entry(unsigned int numlower)

{

	size_t size = offsetof(struct ovl_entry, __lowerstack[numlower]);

	struct ovl_entry *oe = kzalloc(size, GFP_KERNEL);

	struct ovl_entry *oe;



	oe = kzalloc(struct_size(oe, __lowerstack, numlower), GFP_KERNEL);

	if (oe)

		oe->__numlower = numlower;