Unverified Commit 7368e9f4 authored by Markus Elfring's avatar Markus Elfring Committed by Mark Brown
Browse files

regulator: Call of_node_put() only once in rzg2l_usb_vbus_regulator_probe() 



An of_node_put(config.of_node) call was immediately used after a pointer
check for a devm_regulator_register() call in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Link: https://patch.msgid.link/f9d7a026-a67a-4164-80f4-578b1fbf71ac@web.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f4e06afb

drivers/regulator/renesas-usb-vbus-regulator.c

+2 −5
Original line number Diff line number Diff line
@@ -49,13 +49,10 @@ static int rzg2l_usb_vbus_regulator_probe(struct platform_device *pdev) 
		return dev_err_probe(dev, -ENODEV, "regulator node not found\n");



	rdev = devm_regulator_register(dev, &rzg2l_usb_vbus_rdesc, &config);

	if (IS_ERR(rdev)) {

	of_node_put(config.of_node);

	if (IS_ERR(rdev))

		return dev_err_probe(dev, PTR_ERR(rdev),

				     "not able to register vbus regulator\n");

	}



	of_node_put(config.of_node);



	return 0;

}