Commit 736ef29e authored by Yicong Hui's avatar Yicong Hui Committed by Alex Deucher
Browse files

drm/amdgpu: Replace deprecated strcpy() in amdgpu_virt_write_vf2pf_data 



strcpy() is deprecated as it does not do any bounds checking (as
specified in Documentation/process/deprecated.rst).

There is a risk of buffer overflow in the case that the value for
THIS_MODULE->version exceeds the 64 characters. This is unlikely, but
replacing the deprecated function will pre-emptively remove this risk
entirely.

Replace both instances of strcpy() with the safer strscpy() function.

Changes have been compile tested.

Reviewed-by: default avatarKees Cook <kees@kernel.org>
Signed-off-by: default avatarYicong Hui <yiconghui@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 9c7be0ef

drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

+2 −2
Original line number Diff line number Diff line
@@ -605,10 +605,10 @@ static int amdgpu_virt_write_vf2pf_data(struct amdgpu_device *adev) 


#ifdef MODULE

	if (THIS_MODULE->version != NULL)

		strcpy(vf2pf_info->driver_version, THIS_MODULE->version);

		strscpy(vf2pf_info->driver_version, THIS_MODULE->version);

	else

#endif

		strcpy(vf2pf_info->driver_version, "N/A");

		strscpy(vf2pf_info->driver_version, "N/A");



	vf2pf_info->pf2vf_version_required = 0; // no requirement, guest understands all

	vf2pf_info->driver_cert = 0;