Commit 736f0c7a authored by Sean Anderson's avatar Sean Anderson Committed by Jakub Kicinski
Browse files

net: xilinx: axienet: Relax partial rx checksum checks 



The partial rx checksum feature computes a checksum over the entire
packet, regardless of the L3 protocol. Remove the check for IPv4.
Additionally, testing with csum.py (from kselftests) shows no anomalies
with 64-byte packets, so we can remove that check as well.

Signed-off-by: default avatarSean Anderson <sean.anderson@linux.dev>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240909161016.1149119-5-sean.anderson@linux.dev


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 06c069ff

drivers/net/ethernet/xilinx/xilinx_axienet_main.c

+1 −3
Original line number Diff line number Diff line
@@ -1188,9 +1188,7 @@ static int axienet_rx_poll(struct napi_struct *napi, int budget) 
				    csumstatus == XAE_IP_UDP_CSUM_VALIDATED) {

					skb->ip_summed = CHECKSUM_UNNECESSARY;

				}

			} else if ((lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) != 0 &&

				   skb->protocol == htons(ETH_P_IP) &&

				   skb->len > 64) {

			} else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) {

				skb->csum = be32_to_cpu(cur_p->app3 & 0xFFFF);

				skb->ip_summed = CHECKSUM_COMPLETE;

			}