Commit 73c09901 authored by Matthew Brost's avatar Matthew Brost Committed by Rodrigo Vivi
Browse files

drm/xe: Only try to lock external BOs in VM bind 



We only need to try to lock a BO if it's external as non-external BOs
share the dma-resv with the already locked VM. Trying to lock
non-external BOs caused an issue (list corruption) in an uncoming patch
which adds bulk LRU move. Since this code isn't needed, remove it.

v2: New commit message, s/mattthew/matthew/

Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 911cd9b3

drivers/gpu/drm/xe/xe_vm.c

+5 −3
Original line number Diff line number Diff line
@@ -2157,10 +2157,12 @@ static int vm_bind_ioctl(struct xe_vm *vm, struct xe_vma *vma, 
		 */

		xe_bo_get(vbo);



		if (!vbo->vm) {

			tv_bo.bo = &vbo->ttm;

			tv_bo.num_shared = 1;

			list_add(&tv_bo.head, &objs);

		}

	}



again:

	err = ttm_eu_reserve_buffers(&ww, &objs, true, &dups);