Commit 73fa4597 authored by Alexis Lothore's avatar Alexis Lothore Committed by Paolo Abeni
Browse files

net: stmmac: fix dwmac1000 ptp timestamp status offset 



When a PTP interrupt occurs, the driver accesses the wrong offset to
learn about the number of available snapshots in the FIFO for dwmac1000:
it should be accessing bits 29..25, while it is currently reading bits
19..16 (those are bits about the auxiliary triggers which have generated
the timestamps). As a consequence, it does not compute correctly the
number of available snapshots, and so possibly do not generate the
corresponding clock events if the bogus value ends up being 0.

Fix clock events generation by reading the correct bits in the timestamp
register for dwmac1000.

Fixes: 477c3e1f ("net: stmmac: Introduce dwmac1000 timestamping operations")
Signed-off-by: default avatarAlexis Lothoré <alexis.lothore@bootlin.com>
Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20250423-stmmac_ts-v2-1-e2cf2bbd61b1@bootlin.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 607b310a

drivers/net/ethernet/stmicro/stmmac/dwmac1000.h

+2 −2
Original line number Diff line number Diff line
@@ -320,8 +320,8 @@ enum rtc_control { 


/* PTP and timestamping registers */



#define GMAC3_X_ATSNS       GENMASK(19, 16)

#define GMAC3_X_ATSNS_SHIFT 16

#define GMAC3_X_ATSNS       GENMASK(29, 25)

#define GMAC3_X_ATSNS_SHIFT 25



#define GMAC_PTP_TCR_ATSFC	BIT(24)

#define GMAC_PTP_TCR_ATSEN0	BIT(25)