Commit 7450bf76 authored by Lee Jones's avatar Lee Jones Committed by Zack Rusin
Browse files

drm/vmwgfx/vmwgfx_execbuf: Fix some kernel-doc related issues 



Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:89: warning: Enum value 'vmw_res_rel_max' not described in enum 'vmw_resource_relocation_type'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:136: warning: Function parameter or member 'func' not described in 'vmw_cmd_entry'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:136: warning: Function parameter or member 'cmd_name' not described in 'vmw_cmd_entry'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:212: warning: Function parameter or member 'res' not described in 'vmw_cmd_ctx_first_setup'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:523: warning: Function parameter or member 'sw_context' not described in 'vmw_resource_relocation_add'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:523: warning: Excess function parameter 'list' description in 'vmw_resource_relocation_add'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:653: warning: Function parameter or member 'p_res' not described in 'vmw_cmd_res_check'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:653: warning: Excess function parameter 'p_val' description in 'vmw_cmd_res_check'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:1716: warning: Function parameter or member 'res' not described in 'vmw_cmd_res_switch_backup'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:1716: warning: Excess function parameter 'val_node' description in 'vmw_cmd_res_switch_backup'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3757: warning: Function parameter or member 'file_priv' not described in 'vmw_execbuf_fence_commands'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3757: warning: Function parameter or member 'dev_priv' not described in 'vmw_execbuf_fence_commands'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3757: warning: Function parameter or member 'p_fence' not described in 'vmw_execbuf_fence_commands'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3757: warning: Function parameter or member 'p_handle' not described in 'vmw_execbuf_fence_commands'
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3954: warning: Function parameter or member 'kernel_commands' not described in 'vmw_execbuf_cmdbuf'

Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-4-lee.jones@linaro.org
parent 6dd6b764

drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c

+12 −8
Original line number Diff line number Diff line
@@ -80,6 +80,7 @@ struct vmw_relocation { 
 * with a NOP.

 * @vmw_res_rel_cond_nop: Conditional NOP relocation. If the resource id after

 * validation is -1, the command is replaced with a NOP. Otherwise no action.

 * @vmw_res_rel_max: Last value in the enum - used for error checking

*/

enum vmw_resource_relocation_type {

	vmw_res_rel_normal,
@@ -122,9 +123,11 @@ struct vmw_ctx_validation_info { 
/**

 * struct vmw_cmd_entry - Describe a command for the verifier

 *

 * @func: Call-back to handle the command.

 * @user_allow: Whether allowed from the execbuf ioctl.

 * @gb_disable: Whether disabled if guest-backed objects are available.

 * @gb_enable: Whether enabled iff guest-backed objects are available.

 * @cmd_name: Name of the command.

 */

struct vmw_cmd_entry {

	int (*func) (struct vmw_private *, struct vmw_sw_context *,
@@ -203,6 +206,7 @@ static void vmw_bind_dx_query_mob(struct vmw_sw_context *sw_context) 
 *

 * @dev_priv: Pointer to the device private:

 * @sw_context: The command submission context

 * @res: Pointer to the resource

 * @node: The validation node holding the context resource metadata

 */

static int vmw_cmd_ctx_first_setup(struct vmw_private *dev_priv,
@@ -509,7 +513,7 @@ static int vmw_resource_context_res_add(struct vmw_private *dev_priv, 
/**

 * vmw_resource_relocation_add - Add a relocation to the relocation list

 *

 * @list: Pointer to head of relocation list.

 * @sw_context: Pointer to the software context.

 * @res: The resource.

 * @offset: Offset into the command buffer currently being parsed where the id

 * that needs fixup is located. Granularity is one byte.
@@ -639,7 +643,7 @@ static int vmw_resources_reserve(struct vmw_sw_context *sw_context) 
 * @converter: User-space visisble type specific information.

 * @id_loc: Pointer to the location in the command buffer currently being parsed

 * from where the user-space resource id handle is located.

 * @p_val: Pointer to pointer to resource validalidation node. Populated on

 * @p_res: Pointer to pointer to resource validalidation node. Populated on

 * exit.

 */

static int
@@ -1700,7 +1704,7 @@ static int vmw_cmd_check_define_gmrfb(struct vmw_private *dev_priv, 
 *

 * @dev_priv: Pointer to a device private struct.

 * @sw_context: The software context being used for this batch.

 * @val_node: The validation node representing the resource.

 * @res: Pointer to the resource.

 * @buf_id: Pointer to the user-space backup buffer handle in the command

 * stream.

 * @backup_offset: Offset of backup into MOB.
@@ -3739,7 +3743,7 @@ static int vmw_resize_cmd_bounce(struct vmw_sw_context *sw_context, 
	return 0;

}



/**

/*

 * vmw_execbuf_fence_commands - create and submit a command stream fence

 *

 * Creates a fence object and submits a command stream marker.
@@ -3939,9 +3943,9 @@ static int vmw_execbuf_submit_cmdbuf(struct vmw_private *dev_priv, 
 * On successful return, the function returns a pointer to the data in the

 * command buffer and *@header is set to non-NULL.

 *

 * If command buffers could not be used, the function will return the value of

 * @kernel_commands on function call. That value may be NULL. In that case, the

 * value of *@header will be set to NULL.

 * @kernel_commands: If command buffers could not be used, the function will

 * return the value of @kernel_commands on function call. That value may be

 * NULL. In that case, the value of *@header will be set to NULL.

 *

 * If an error is encountered, the function will return a pointer error value.

 * If the function is interrupted by a signal while sleeping, it will return