Commit 7462e460 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: omapfb/opa362: Don't put .remove() in .exit.text and drop suppress_bind_attrs 



On today's platforms the memory savings of putting the remove function
in .exit isn't that relevant any more. It only matters for built-in
drivers and typically saves a few 100k.

The downside is that the driver cannot be unbound at runtime which is
ancient and also slightly complicates testing. Also it requires to mark
the driver struct with __refdata which is needed to suppress a (W=1)
modpost warning:

	WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410: section mismatch in reference: tfp410_driver+0x4 (section: .data) -> tfp410_remove (section: .exit.text)

To simplify matters, move the remove callback to .text and drop
.suppress_bind_attrs = true.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 1fc9ea05

drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c

+2 −3
Original line number Diff line number Diff line
@@ -231,7 +231,7 @@ static int opa362_probe(struct platform_device *pdev) 
	return r;

}



static int __exit opa362_remove(struct platform_device *pdev)

static int opa362_remove(struct platform_device *pdev)

{

	struct panel_drv_data *ddata = platform_get_drvdata(pdev);

	struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -260,11 +260,10 @@ MODULE_DEVICE_TABLE(of, opa362_of_match); 


static struct platform_driver opa362_driver = {

	.probe	= opa362_probe,

	.remove	= __exit_p(opa362_remove),

	.remove	= opa362_remove,

	.driver	= {

		.name	= "amplifier-opa362",

		.of_match_table = opa362_of_match,

		.suppress_bind_attrs = true,

	},

};