Commit 748b3c4c authored by Duncan Ma's avatar Duncan Ma Committed by Alex Deucher
Browse files

drm/amd/display: Add visual confirm for Idle State 



[Why]
Visual Confirm would tell us if it ever
entered idle state.

[How]
Add debug option for IPS visual confirm

Reviewed-by: default avatarOvidiu Bunea <ovidiu.bunea@amd.com>
Signed-off-by: default avatarJerry Zuo <jerry.zuo@amd.com>
Signed-off-by: default avatarDuncan Ma <duncan.ma@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent acce1eb8

drivers/gpu/drm/amd/display/dc/dc.h

+1 −0
Original line number Diff line number Diff line
@@ -1056,6 +1056,7 @@ struct dc_debug_options { 
	unsigned int force_sharpness;

	unsigned int force_lls;

	bool notify_dpia_hr_bw;

	bool enable_ips_visual_confirm;

};

drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c

+1 −0
Original line number Diff line number Diff line
@@ -363,6 +363,7 @@ static bool dmub_psr_copy_settings(struct dmub_psr *dmub, 
	copy_settings_data->debug.bitfields.visual_confirm	= dc->dc->debug.visual_confirm == VISUAL_CONFIRM_PSR;

	copy_settings_data->debug.bitfields.use_hw_lock_mgr		= 1;

	copy_settings_data->debug.bitfields.force_full_frame_update	= 0;

	copy_settings_data->debug.bitfields.enable_ips_visual_confirm = dc->dc->debug.enable_ips_visual_confirm;



	if (psr_context->su_granularity_required == 0)

		copy_settings_data->su_y_granularity = 0;

drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c

+2 −0
Original line number Diff line number Diff line
@@ -167,6 +167,8 @@ static bool dmub_replay_copy_settings(struct dmub_replay *dmub, 
	copy_settings_data->smu_optimizations_en		= link->replay_settings.replay_smu_opt_enable;

	copy_settings_data->replay_timing_sync_supported = link->replay_settings.config.replay_timing_sync_supported;



	copy_settings_data->debug.bitfields.enable_ips_visual_confirm = dc->dc->debug.enable_ips_visual_confirm;



	copy_settings_data->flags.u32All = 0;

	copy_settings_data->flags.bitfields.fec_enable_status = (link->fec_state == dc_link_fec_enabled);

	copy_settings_data->flags.bitfields.dsc_enable_status = (pipe_ctx->stream->timing.flags.DSC == 1);

drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

+4 −0
Original line number Diff line number Diff line
@@ -336,6 +336,10 @@ union dmub_psr_debug_flags { 
		 */

		uint32_t back_to_back_flip : 1;



		/**

		 * Enable visual confirm for IPS

		 */

		uint32_t enable_ips_visual_confirm : 1;

	} bitfields;



	/**