Commit 748e21d9 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Kalle Valo
Browse files

wifi: mwl8k: Use static_assert() to check struct sizes 



Commit 5c425009 ("wifi: mwl8k: Avoid -Wflex-array-member-not-at-end
warnings") introduced tagged `struct mwl8k_cmd_pkt_hdr`. We want to
ensure that when new members need to be added to the flexible structure,
they are always included within this tagged struct.

We use `static_assert()` to ensure that the memory layout for both
the flexible structure and the tagged struct is the same after any
changes.

Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/ZrVCg51Q9M2fTPaF@cute
parent cc32e9fb

drivers/net/wireless/marvell/mwl8k.c

+3 −0
Original line number Diff line number Diff line
@@ -587,6 +587,7 @@ static int mwl8k_request_firmware(struct mwl8k_priv *priv, char *fw_image, 
}



struct mwl8k_cmd_pkt {

	/* New members MUST be added within the __struct_group() macro below. */

	__struct_group(mwl8k_cmd_pkt_hdr, hdr, __packed,

		__le16	code;

		__le16	length;
@@ -596,6 +597,8 @@ struct mwl8k_cmd_pkt { 
	);

	char payload[];

} __packed;

static_assert(offsetof(struct mwl8k_cmd_pkt, payload) == sizeof(struct mwl8k_cmd_pkt_hdr),

	      "struct member likely outside of __struct_group()");



/*

 * Firmware loading.