Unverified Commit 7556fe21 authored by Iker Pedrosa's avatar Iker Pedrosa Committed by Javier Martinez Canillas
Browse files

drm/solomon: Simplify mode_valid() using DRM helper 



The ssd130x_crtc_mode_valid() function contains a manual implementation
to validate the display mode against the panel's single fixed resolution.

This pattern is common for simple displays, and the DRM core already
provides the drm_crtc_helper_mode_valid_fixed() helper for this exact
use case.

Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: default avatarIker Pedrosa <ikerpedrosam@gmail.com>
Link: https://lore.kernel.org/r/20250920-improve-ssd130x-v2-3-77721e87ae08@gmail.com


Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
parent 683bb242

drivers/gpu/drm/solomon/ssd130x.c

+1 −9
Original line number Diff line number Diff line
@@ -1473,15 +1473,7 @@ static enum drm_mode_status ssd130x_crtc_mode_valid(struct drm_crtc *crtc, 
{

	struct ssd130x_device *ssd130x = drm_to_ssd130x(crtc->dev);



	if (mode->hdisplay != ssd130x->mode.hdisplay &&

	    mode->vdisplay != ssd130x->mode.vdisplay)

		return MODE_ONE_SIZE;

	else if (mode->hdisplay != ssd130x->mode.hdisplay)

		return MODE_ONE_WIDTH;

	else if (mode->vdisplay != ssd130x->mode.vdisplay)

		return MODE_ONE_HEIGHT;



	return MODE_OK;

	return drm_crtc_helper_mode_valid_fixed(crtc, mode, &ssd130x->mode);

}



static int ssd130x_crtc_atomic_check(struct drm_crtc *crtc,