Commit 758d5d64 authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring/uring_cmd: assign ioucmd->cmd at async prep time 



Rather than check this in the fast path issue, it makes more sense to
just assign the copy of the data when we're setting it up anyway. This
makes the code a bit cleaner, and removes the need for this check in
the issue path.

Reviewed-by: default avatarGabriel Krisman Bertazi <krisman@suse.de>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 69bbc6ad

io_uring/uring_cmd.c

+1 −3
Original line number Diff line number Diff line
@@ -73,6 +73,7 @@ int io_uring_cmd_prep_async(struct io_kiocb *req) 
	cmd_size = uring_cmd_pdu_size(req->ctx->flags & IORING_SETUP_SQE128);



	memcpy(req->async_data, ioucmd->cmd, cmd_size);

	ioucmd->cmd = req->async_data;

	return 0;

}
@@ -129,9 +130,6 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) 
		WRITE_ONCE(ioucmd->cookie, NULL);

	}



	if (req_has_async_data(req))

		ioucmd->cmd = req->async_data;



	ret = file->f_op->uring_cmd(ioucmd, issue_flags);

	if (ret == -EAGAIN) {

		if (!req_has_async_data(req)) {