Unverified Commit 7596459f authored by Vinay Belgaumkar's avatar Vinay Belgaumkar Committed by Rodrigo Vivi
Browse files

drm/xe: Fix bug in idledly unit conversion 



We only need to convert to picosecond units before writing to RING_IDLEDLY.

Fixes: 7c53ff05 ("drm/xe: Apply Wa_16023105232")
Cc: Tangudu Tilak Tirumalesh <tilak.tirumalesh.tangudu@intel.com>
Acked-by: default avatarTangudu Tilak Tirumalesh <tilak.tirumalesh.tangudu@intel.com>
Signed-off-by: default avatarVinay Belgaumkar <vinay.belgaumkar@intel.com>
Link: https://patch.msgid.link/20260401012710.4165547-1-vinay.belgaumkar@intel.com


(cherry picked from commit 13743bd628bc9d9a0e2fe53488b2891aedf7cc74)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 591cd656

drivers/gpu/drm/xe/xe_hw_engine.c

+1 −2
Original line number Diff line number Diff line
@@ -595,9 +595,8 @@ static void adjust_idledly(struct xe_hw_engine *hwe) 
		maxcnt *= maxcnt_units_ns;



		if (xe_gt_WARN_ON(gt, idledly >= maxcnt || inhibit_switch)) {

			idledly = DIV_ROUND_CLOSEST(((maxcnt - 1) * maxcnt_units_ns),

			idledly = DIV_ROUND_CLOSEST(((maxcnt - 1) * 1000),

						    idledly_units_ps);

			idledly = DIV_ROUND_CLOSEST(idledly, 1000);

			xe_mmio_write32(&gt->mmio, RING_IDLEDLY(hwe->mmio_base), idledly);

		}

	}