Unverified Commit 762a3847 authored Mar 21, 2026 by Kexin Sun Committed by Mark Brown Mar 24, 2026

spi: pxa2xx: update outdated reference to pump_transfers()



The function pump_transfers() was split into
pxa2xx_spi_transfer_one(), pxa2xx_spi_handle_err() and
pxa2xx_spi_set_cs() in commit d5898e19 ("spi: pxa2xx: Use
core message processing loop").  The comment in
pxa2xx_spi_dma_transfer_complete() still warns about concurrent
calls to pump_transfers(), but the actual operation protected by
dma_running is now spi_finalize_current_transfer().  Update the
reference.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
Link: https://patch.msgid.link/20260321105945.8224-1-kexinsun@smail.nju.edu.cn


Signed-off-by: Mark Brown <broonie@kernel.org>

parent fa0561a1

drivers/spi/spi-pxa2xx-dma.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -29,9 +29,9 @@ static void pxa2xx_spi_dma_transfer_complete(struct driver_data *drv_data,

		/*
		* It is possible that one CPU is handling ROR interrupt and other
		* just gets DMA completion. Calling pump_transfers() twice for the
		* same transfer leads to problems thus we prevent concurrent calls
		* by using dma_running.
		* just gets DMA completion. Calling spi_finalize_current_transfer()
		* twice for the same transfer leads to problems thus we prevent
		* concurrent calls by using dma_running.
		*/
		if (atomic_dec_and_test(&drv_data->dma_running)) {
		/*