Commit 769d7fbe authored May 07, 2025 by Benjamin Block Committed by Martin K. Petersen May 12, 2025

scsi: zfcp: Simplify workqueue allocation



alloc_ordered_workqueue() accepts a format string and format arguments as
part of the call, so there is no need for the indirection of first using
snprintf() to print the name into an local array, and then passing that
array to the allocation call.

Also make the error-/non-error-case handling more canonical in that the
error case is tested in the 'if' that follows the allocation call, and
the default return value of the function is '0'.

Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
Reviewed-by: Fedor Loshakov <loshakov@linux.ibm.com>
Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Reviewed-by: M Nikhil <nikh1092@linux.ibm.com>
Reviewed-by: Nihar Panda <niharp@linux.ibm.com>
Signed-off-by: Nihar Panda <niharp@linux.ibm.com>
Link: https://lore.kernel.org/r/20250507042854.3607038-3-niharp@linux.ibm.com


Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 4a9a7c82

drivers/s390/scsi/zfcp_aux.c

+6 −8

Original line number	Diff line number	Diff line
		@@ -312,15 +312,13 @@ static void zfcp_print_sl(struct seq_file m, struct service_level sl)

		static int zfcp_setup_adapter_work_queue(struct zfcp_adapter *adapter)
		{
		char name[TASK_COMM_LEN];

		snprintf(name, sizeof(name), "zfcp_q_%s",
		adapter->work_queue =
		alloc_ordered_workqueue("zfcp_q_%s", WQ_MEM_RECLAIM,
		dev_name(&adapter->ccw_device->dev));
		adapter->work_queue = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
		if (!adapter->work_queue)
		return -ENOMEM;

		if (adapter->work_queue)
		return 0;
		return -ENOMEM;
		}

		static void zfcp_destroy_adapter_work_queue(struct zfcp_adapter *adapter)