Commit 76a2d839 authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Paolo Abeni
Browse files

selftests: mptcp: join: no extra msg if no counter 



The checksum and fail counters might not be available. Then no need to
display an extra message with missing info.

While at it, fix the indentation around, which is wrong since the same
commit.

Fixes: 47867f0a ("selftests: mptcp: join: skip check if MIB counter not supported")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarGeliang Tang <geliang@kernel.org>
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 1c2326fc

tools/testing/selftests/net/mptcp/mptcp_join.sh

+8 −8
Original line number Diff line number Diff line
@@ -1112,7 +1112,7 @@ chk_csum_nr() 


	print_check "sum"

	count=$(mptcp_lib_get_counter ${ns1} "MPTcpExtDataCsumErr")

	if [ "$count" != "$csum_ns1" ]; then

	if [ -n "$count" ] && [ "$count" != "$csum_ns1" ]; then

		extra_msg+=" ns1=$count"

	fi

	if [ -z "$count" ]; then
@@ -1125,7 +1125,7 @@ chk_csum_nr() 
	fi

	print_check "csum"

	count=$(mptcp_lib_get_counter ${ns2} "MPTcpExtDataCsumErr")

	if [ "$count" != "$csum_ns2" ]; then

	if [ -n "$count" ] && [ "$count" != "$csum_ns2" ]; then

		extra_msg+=" ns2=$count"

	fi

	if [ -z "$count" ]; then
@@ -1169,7 +1169,7 @@ chk_fail_nr() 


	print_check "ftx"

	count=$(mptcp_lib_get_counter ${ns_tx} "MPTcpExtMPFailTx")

	if [ "$count" != "$fail_tx" ]; then

	if [ -n "$count" ] && [ "$count" != "$fail_tx" ]; then

		extra_msg+=",tx=$count"

	fi

	if [ -z "$count" ]; then
@@ -1183,7 +1183,7 @@ chk_fail_nr() 


	print_check "failrx"

	count=$(mptcp_lib_get_counter ${ns_rx} "MPTcpExtMPFailRx")

	if [ "$count" != "$fail_rx" ]; then

	if [ -n "$count" ] && [ "$count" != "$fail_rx" ]; then

		extra_msg+=",rx=$count"

	fi

	if [ -z "$count" ]; then