Commit 76ce6e6e authored by David Lechner's avatar David Lechner Committed by Jonathan Cameron
Browse files

iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep 



Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
gpiod_set_array_value().

These are not called in an atomic context, so changing to the cansleep
variant is fine.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarDavid Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20250210-gpio-set-array-helper-v3-9-d6a673674da8@baylibre.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent a927e729

drivers/iio/resolver/ad2s1210.c

+2 −6
Original line number Diff line number Diff line
@@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) 


	bitmap[0] = mode;



	return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info,

				     bitmap);

	return gpiod_multi_set_value_cansleep(gpios, bitmap);

}



/*
@@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) 


		bitmap[0] = st->resolution;



		ret = gpiod_set_array_value(resolution_gpios->ndescs,

					    resolution_gpios->desc,

					    resolution_gpios->info,

					    bitmap);

		ret = gpiod_multi_set_value_cansleep(resolution_gpios, bitmap);

		if (ret < 0)

			return dev_err_probe(dev, ret,

					     "failed to set resolution gpios\n");