Commit 76f0d6f5 authored by Daniel Latypov's avatar Daniel Latypov Committed by Shuah Khan
Browse files

kunit: tool: drop unused load_config argument 



It's always set to true except in one test case.
And in that test case it can safely be set to true anyways.

Signed-off-by: default avatarDaniel Latypov <dlatypov@google.com>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Reviewed-by: default avatarBrendan Higgins <brendanhiggins@google.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent d2fbdde8

tools/testing/kunit/kunit_kernel.py

+0 −4
Original line number Diff line number Diff line
@@ -219,7 +219,6 @@ class LinuxSourceTree: 
	def __init__(

	      self,

	      build_dir: str,

	      load_config=True,

	      kunitconfig_path='',

	      kconfig_add: Optional[List[str]]=None,

	      arch=None,
@@ -233,9 +232,6 @@ class LinuxSourceTree: 
			self._arch = 'um' if arch is None else arch

			self._ops = get_source_tree_ops(self._arch, cross_compile)



		if not load_config:

			return



		if kunitconfig_path:

			if os.path.isdir(kunitconfig_path):

				kunitconfig_path = os.path.join(kunitconfig_path, KUNITCONFIG_PATH)

tools/testing/kunit/kunit_tool_test.py

+1 −1
Original line number Diff line number Diff line
@@ -393,7 +393,7 @@ class LinuxSourceTreeTest(unittest.TestCase): 
			return subprocess.Popen(['echo "hi\nbye"'], shell=True, text=True, stdout=subprocess.PIPE)



		with tempfile.TemporaryDirectory('') as build_dir:

			tree = kunit_kernel.LinuxSourceTree(build_dir, load_config=False)

			tree = kunit_kernel.LinuxSourceTree(build_dir)

			mock.patch.object(tree._ops, 'start', side_effect=fake_start).start()



			with self.assertRaises(ValueError):