Unverified Commit 7757f9d5 authored by Kurt Borja's avatar Kurt Borja Committed by Ilpo Järvinen
Browse files

alienware-wmi: fixed indentation and clean up 



Fixed inconsistent indentation and removed unnecessary (acpi_size) and
(u32 *) casts.

Signed-off-by: default avatarKurt Borja <kuurtb@gmail.com>
Reviewed-by: default avatarArmin Wolf <W_Armin@gmx.de>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20241030001028.7402-2-kuurtb@gmail.com


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent f6093339

drivers/platform/x86/dell/alienware-wmi.c

+67 −67
Original line number Diff line number Diff line
@@ -292,7 +292,7 @@ static int alienware_update_led(struct platform_zone *zone) 
		guid = WMAX_CONTROL_GUID;

		method_id = WMAX_METHOD_ZONE_CONTROL;



		input.length = (acpi_size) sizeof(wmax_basic_args);

		input.length = sizeof(wmax_basic_args);

		input.pointer = &wmax_basic_args;

	} else {

		legacy_args.colors = zone->colors;
@@ -306,7 +306,7 @@ static int alienware_update_led(struct platform_zone *zone) 
			guid = LEGACY_CONTROL_GUID;

		method_id = zone->location + 1;



		input.length = (acpi_size) sizeof(legacy_args);

		input.length = sizeof(legacy_args);

		input.pointer = &legacy_args;

	}

	pr_debug("alienware-wmi: guid %s method %d\n", guid, method_id);
@@ -358,7 +358,7 @@ static int wmax_brightness(int brightness) 
		.led_mask = 0xFF,

		.percentage = brightness,

	};

	input.length = (acpi_size) sizeof(args);

	input.length = sizeof(args);

	input.pointer = &args;

	status = wmi_evaluate_method(WMAX_CONTROL_GUID, 0,

				     WMAX_METHOD_BRIGHTNESS, &input, NULL);
@@ -508,7 +508,7 @@ static acpi_status alienware_wmax_command(struct wmax_basic_args *in_args, 
	struct acpi_buffer input;

	struct acpi_buffer output;



	input.length = (acpi_size) sizeof(*in_args);

	input.length = sizeof(*in_args);

	input.pointer = in_args;

	if (out_data) {

		output.length = ACPI_ALLOCATE_BUFFER;
@@ -542,7 +542,7 @@ static ssize_t show_hdmi_cable(struct device *dev, 
	};

	status =

	    alienware_wmax_command(&in_args, WMAX_METHOD_HDMI_CABLE,

				   (u32 *) &out_data);

				   &out_data);

	if (ACPI_SUCCESS(status)) {

		if (out_data == 0)

			return sysfs_emit(buf, "[unconnected] connected unknown\n");
@@ -563,7 +563,7 @@ static ssize_t show_hdmi_source(struct device *dev, 
	};

	status =

	    alienware_wmax_command(&in_args, WMAX_METHOD_HDMI_STATUS,

				   (u32 *) &out_data);

				   &out_data);



	if (ACPI_SUCCESS(status)) {

		if (out_data == 1)
@@ -643,7 +643,7 @@ static ssize_t show_amplifier_status(struct device *dev, 
	};

	status =

	    alienware_wmax_command(&in_args, WMAX_METHOD_AMPLIFIER_CABLE,

				   (u32 *) &out_data);

				   &out_data);

	if (ACPI_SUCCESS(status)) {

		if (out_data == 0)

			return sysfs_emit(buf, "[unconnected] connected unknown\n");
@@ -695,7 +695,7 @@ static ssize_t show_deepsleep_status(struct device *dev, 
		.arg = 0,

	};

	status = alienware_wmax_command(&in_args, WMAX_METHOD_DEEP_SLEEP_STATUS,

					(u32 *) &out_data);

					&out_data);

	if (ACPI_SUCCESS(status)) {

		if (out_data == 0)

			return sysfs_emit(buf, "[disabled] s5 s5_s4\n");