Commit 776dac5a authored by Kunwu Chan's avatar Kunwu Chan Committed by Jakub Kicinski
Browse files

net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe 



devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: 05bd97fc ("net: dsa: Add Vitesse VSC73xx DSA router driver")
Signed-off-by: default avatarKunwu Chan <chentao@kylinos.cn>
Suggested-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240111072018.75971-1-chentao@kylinos.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 03fb8565

drivers/net/dsa/vitesse-vsc73xx-core.c

+2 −0
Original line number Diff line number Diff line
@@ -1135,6 +1135,8 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc) 


	vsc->gc.label = devm_kasprintf(vsc->dev, GFP_KERNEL, "VSC%04x",

				       vsc->chipid);

	if (!vsc->gc.label)

		return -ENOMEM;

	vsc->gc.ngpio = 4;

	vsc->gc.owner = THIS_MODULE;

	vsc->gc.parent = vsc->dev;