Unverified Commit 7781f1d1 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown
Browse files

spi: ppc4xx: Avoid returning 0 when failed to parse and map IRQ 



0 is incorrect error code when failed to parse and map IRQ.
Replace OF specific old API for IRQ retrieval with a generic
one to fix this issue.

Fixes: 0f245463 ("spi: ppc4xx: handle irq_of_parse_and_map() errors")
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20240814144525.2648450-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f1011ba2

drivers/spi/spi-ppc4xx.c

+3 −3
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ 
#include <linux/wait.h>

#include <linux/platform_device.h>

#include <linux/of_address.h>

#include <linux/of_irq.h>

#include <linux/of_platform.h>

#include <linux/interrupt.h>

#include <linux/delay.h>
@@ -412,9 +411,10 @@ static int spi_ppc4xx_of_probe(struct platform_device *op) 
	}



	/* Request IRQ */

	hw->irqnum = irq_of_parse_and_map(np, 0);

	if (hw->irqnum <= 0)

	ret = platform_get_irq(op, 0);

	if (ret < 0)

		goto free_host;

	hw->irqnum = ret;



	if (hw->irqnum <= 0)

		goto free_host;