Commit 778dfacc authored by Guanjun's avatar Guanjun Committed by Vinod Koul
Browse files

dmaengine: idxd: Protect int_handle field in hw descriptor 



The int_handle field in hw descriptor should also be protected
by wmb() before possibly triggering a DMA read.

Fixes: eb0cf33a (dmaengine: idxd: move interrupt handle assignment)
Signed-off-by: default avatarGuanjun <guanjun@linux.alibaba.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarFenghua Yu <fenghua.yu@intel.com>
Reviewed-by: default avatarLijun Pan <lijun.pan@intel.com>
Link: https://lore.kernel.org/r/20231211053704.2725417-2-guanjun@linux.alibaba.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 54bed6ba

drivers/dma/idxd/submit.c

+7 −7
Original line number Diff line number Diff line
@@ -182,13 +182,6 @@ int idxd_submit_desc(struct idxd_wq *wq, struct idxd_desc *desc) 


	portal = idxd_wq_portal_addr(wq);



	/*

	 * The wmb() flushes writes to coherent DMA data before

	 * possibly triggering a DMA read. The wmb() is necessary

	 * even on UP because the recipient is a device.

	 */

	wmb();



	/*

	 * Pending the descriptor to the lockless list for the irq_entry

	 * that we designated the descriptor to.
@@ -199,6 +192,13 @@ int idxd_submit_desc(struct idxd_wq *wq, struct idxd_desc *desc) 
		llist_add(&desc->llnode, &ie->pending_llist);

	}



	/*

	 * The wmb() flushes writes to coherent DMA data before

	 * possibly triggering a DMA read. The wmb() is necessary

	 * even on UP because the recipient is a device.

	 */

	wmb();



	if (wq_dedicated(wq)) {

		iosubmit_cmds512(portal, desc->hw, 1);

	} else {