Commit 77ba4640 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: twl6040: use new GPIO line value setter callbacks 

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250707-gpiochip-set-rv-gpio-round4-v1-8-35668aaaf6d2@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 0446ce28

drivers/gpio/gpio-twl6040.c

+5 −4
Original line number Diff line number Diff line
@@ -44,7 +44,8 @@ static int twl6040gpo_direction_out(struct gpio_chip *chip, unsigned offset, 
	return 0;

}



static void twl6040gpo_set(struct gpio_chip *chip, unsigned offset, int value)

static int twl6040gpo_set(struct gpio_chip *chip, unsigned int offset,

			  int value)

{

	struct twl6040 *twl6040 = gpiochip_get_data(chip);

	int ret;
@@ -52,14 +53,14 @@ static void twl6040gpo_set(struct gpio_chip *chip, unsigned offset, int value) 


	ret = twl6040_reg_read(twl6040, TWL6040_REG_GPOCTL);

	if (ret < 0)

		return;

		return ret;



	if (value)

		gpoctl = ret | BIT(offset);

	else

		gpoctl = ret & ~BIT(offset);



	twl6040_reg_write(twl6040, TWL6040_REG_GPOCTL, gpoctl);

	return twl6040_reg_write(twl6040, TWL6040_REG_GPOCTL, gpoctl);

}



static struct gpio_chip twl6040gpo_chip = {
@@ -68,7 +69,7 @@ static struct gpio_chip twl6040gpo_chip = { 
	.get			= twl6040gpo_get,

	.direction_output	= twl6040gpo_direction_out,

	.get_direction		= twl6040gpo_get_direction,

	.set			= twl6040gpo_set,

	.set_rv			= twl6040gpo_set,

	.can_sleep		= true,

};