Commit 7865dfb1 authored by John Fastabend's avatar John Fastabend Committed by Martin KaFai Lau
Browse files

bpf: sockmap, added comments describing update proto rules 



Add a comment describing that the psock update proto callbback can be
called multiple times and this must be safe.

Signed-off-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Signed-off-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
Reviewed-by: default avatarJakub Sitnicki <jakub@cloudflare.com>
Link: https://lore.kernel.org/r/20231221232327.43678-3-john.fastabend@gmail.com
parent 16b2f264

include/linux/skmsg.h

+5 −0
Original line number Diff line number Diff line
@@ -100,6 +100,11 @@ struct sk_psock { 
	void (*saved_close)(struct sock *sk, long timeout);

	void (*saved_write_space)(struct sock *sk);

	void (*saved_data_ready)(struct sock *sk);

	/* psock_update_sk_prot may be called with restore=false many times

	 * so the handler must be safe for this case. It will be called

	 * exactly once with restore=true when the psock is being destroyed

	 * and psock refcnt is zero, but before an RCU grace period.

	 */

	int  (*psock_update_sk_prot)(struct sock *sk, struct sk_psock *psock,

				     bool restore);

	struct proto			*sk_proto;