Commit 786eb990 authored by Donet Tom's avatar Donet Tom Committed by Andrew Morton
Browse files

drivers/base/node: handle error properly in register_one_node() 

If register_node() returns an error, it is not handled correctly.
The function will proceed further and try to register CPUs under the
node, which is not correct.

So, in this patch, if register_node() returns an error, we return
immediately from the function.

Link: https://lkml.kernel.org/r/20250822084845.19219-1-donettom@linux.ibm.com


Fixes: 76b67ed9 ("[PATCH] node hotplug: register cpu: remove node struct")
Signed-off-by: default avatarDonet Tom <donettom@linux.ibm.com>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Cc: Alison Schofield <alison.schofield@intel.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Donet Tom <donettom@linux.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Joanthan Cameron <Jonathan.Cameron@huawei.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Cc: Yury Norov (NVIDIA) <yury.norov@gmail.com>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 3615e106

drivers/base/node.c

+5 −0
Original line number Diff line number Diff line
@@ -885,6 +885,11 @@ int register_one_node(int nid) 
	node_devices[nid] = node;



	error = register_node(node_devices[nid], nid);

	if (error) {

		node_devices[nid] = NULL;

		kfree(node);

		return error;

	}



	/* link cpu under this node */

	for_each_present_cpu(cpu) {