Commit 78a2f5e6 authored by Jiri Pirko's avatar Jiri Pirko Committed by Jakub Kicinski
Browse files

devlink: fix port new reply cmd type 



Due to a c&p error, port new reply fills-up cmd with wrong value,
any other existing port command replies and notifications.

Fix it by filling cmd with value DEVLINK_CMD_PORT_NEW.

Skimmed through devlink userspace implementations, none of them cares
about this cmd value.

Reported-by: default avatarChenyuan Yang <chenyuan0y@gmail.com>
Closes: https://lore.kernel.org/all/ZfZcDxGV3tSy4qsV@cy-server/


Fixes: cd76dcd6 ("devlink: Support add and delete devlink port")
Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarParav Pandit <parav@nvidia.com>
Reviewed-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Link: https://lore.kernel.org/r/20240318091908.2736542-1-jiri@resnulli.us


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 956c0d61

net/devlink/port.c

+1 −1
Original line number Diff line number Diff line
@@ -889,7 +889,7 @@ int devlink_nl_port_new_doit(struct sk_buff *skb, struct genl_info *info) 
		err = -ENOMEM;

		goto err_out_port_del;

	}

	err = devlink_nl_port_fill(msg, devlink_port, DEVLINK_CMD_NEW,

	err = devlink_nl_port_fill(msg, devlink_port, DEVLINK_CMD_PORT_NEW,

				   info->snd_portid, info->snd_seq, 0, NULL);

	if (WARN_ON_ONCE(err))

		goto err_out_msg_free;