Commit 78afdada authored by Samiullah Khawaja's avatar Samiullah Khawaja Committed by Jakub Kicinski
Browse files

net: Use netif_threaded_enable instead of netif_set_threaded in drivers 



Prepare for adding an enum type for NAPI threaded states by adding
netif_threaded_enable API. De-export the existing netif_set_threaded API
and only use it internally. Update existing drivers to use
netif_threaded_enable instead of the de-exported netif_set_threaded.

Note that dev_set_threaded used by mt76 debugfs file is unchanged.

Signed-off-by: default avatarSamiullah Khawaja <skhawaja@google.com>
Link: https://patch.msgid.link/20250723013031.2911384-3-skhawaja@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 71c52411

drivers/net/ethernet/atheros/atl1c/atl1c_main.c

+1 −1
Original line number Diff line number Diff line
@@ -2688,7 +2688,7 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	adapter->mii.mdio_write = atl1c_mdio_write;

	adapter->mii.phy_id_mask = 0x1f;

	adapter->mii.reg_num_mask = MDIO_CTRL_REG_MASK;

	netif_set_threaded(netdev, true);

	netif_threaded_enable(netdev);

	for (i = 0; i < adapter->rx_queue_count; ++i)

		netif_napi_add(netdev, &adapter->rrd_ring[i].napi,

			       atl1c_clean_rx);

drivers/net/ethernet/mellanox/mlxsw/pci.c

+1 −1
Original line number Diff line number Diff line
@@ -156,7 +156,7 @@ static int mlxsw_pci_napi_devs_init(struct mlxsw_pci *mlxsw_pci) 
	}

	strscpy(mlxsw_pci->napi_dev_rx->name, "mlxsw_rx",

		sizeof(mlxsw_pci->napi_dev_rx->name));

	netif_set_threaded(mlxsw_pci->napi_dev_rx, true);

	netif_threaded_enable(mlxsw_pci->napi_dev_rx);



	return 0;

drivers/net/ethernet/renesas/ravb_main.c

+1 −1
Original line number Diff line number Diff line
@@ -3075,7 +3075,7 @@ static int ravb_probe(struct platform_device *pdev) 
	if (info->coalesce_irqs) {

		netdev_sw_irq_coalesce_default_on(ndev);

		if (num_present_cpus() == 1)

			netif_set_threaded(ndev, true);

			netif_threaded_enable(ndev);

	}



	/* Network device register */

drivers/net/wireguard/device.c

+1 −1
Original line number Diff line number Diff line
@@ -366,7 +366,7 @@ static int wg_newlink(struct net_device *dev, 
	if (ret < 0)

		goto err_free_handshake_queue;



	netif_set_threaded(dev, true);

	netif_threaded_enable(dev);

	ret = register_netdevice(dev);

	if (ret < 0)

		goto err_uninit_ratelimiter;

drivers/net/wireless/ath/ath10k/snoc.c

+1 −1
Original line number Diff line number Diff line
@@ -936,7 +936,7 @@ static int ath10k_snoc_hif_start(struct ath10k *ar) 


	bitmap_clear(ar_snoc->pending_ce_irqs, 0, CE_COUNT_MAX);



	netif_set_threaded(ar->napi_dev, true);

	netif_threaded_enable(ar->napi_dev);

	ath10k_core_napi_enable(ar);

	/* IRQs are left enabled when we restart due to a firmware crash */

	if (!test_bit(ATH10K_SNOC_FLAG_RECOVERY, &ar_snoc->flags))