Commit 78c91bec authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: stmmac: mdio: remove redundant clock rate tests 



The pattern:

	... if (v < A)
		...
	else if (v >= A && v < B)
		...

can be simplified to:

	... if (v < A)
		...
	else if (v < B)
		...

which makes the string of ifelse more readable.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Tested-by: default avatarMohd Ayaan Anwar <quic_mohdayaa@quicinc.com>
Link: https://patch.msgid.link/E1uu8oc-00000001vpN-0S1A@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 231e2b01

drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

+7 −7
Original line number Diff line number Diff line
@@ -502,19 +502,19 @@ static u32 stmmac_clk_csr_set(struct stmmac_priv *priv) 
	 */

	if (clk_rate < CSR_F_35M)

		value = STMMAC_CSR_20_35M;

	else if ((clk_rate >= CSR_F_35M) && (clk_rate < CSR_F_60M))

	else if (clk_rate < CSR_F_60M)

		value = STMMAC_CSR_35_60M;

	else if ((clk_rate >= CSR_F_60M) && (clk_rate < CSR_F_100M))

	else if (clk_rate < CSR_F_100M)

		value = STMMAC_CSR_60_100M;

	else if ((clk_rate >= CSR_F_100M) && (clk_rate < CSR_F_150M))

	else if (clk_rate < CSR_F_150M)

		value = STMMAC_CSR_100_150M;

	else if ((clk_rate >= CSR_F_150M) && (clk_rate < CSR_F_250M))

	else if (clk_rate < CSR_F_250M)

		value = STMMAC_CSR_150_250M;

	else if ((clk_rate >= CSR_F_250M) && (clk_rate <= CSR_F_300M))

	else if (clk_rate <= CSR_F_300M)

		value = STMMAC_CSR_250_300M;

	else if ((clk_rate >= CSR_F_300M) && (clk_rate < CSR_F_500M))

	else if (clk_rate < CSR_F_500M)

		value = STMMAC_CSR_300_500M;

	else if ((clk_rate >= CSR_F_500M) && (clk_rate < CSR_F_800M))

	else if (clk_rate < CSR_F_800M)

		value = STMMAC_CSR_500_800M;



	if (priv->plat->flags & STMMAC_FLAG_HAS_SUN8I) {