Commit 78ededb6 authored by Chia-I Wu's avatar Chia-I Wu Committed by Steven Price
Browse files

panthor: set owner field for driver fops 



It allows us to get rid of manual try_module_get / module_put.

Signed-off-by: default avatarChia-I Wu <olvaffe@gmail.com>
Reviewed-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Signed-off-by: default avatarSteven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/20250718063816.1452123-2-olvaffe@gmail.com
parent 1511d3c4

drivers/gpu/drm/panthor/panthor_drv.c

+3 −11
Original line number Diff line number Diff line
@@ -1401,14 +1401,9 @@ panthor_open(struct drm_device *ddev, struct drm_file *file) 
	struct panthor_file *pfile;

	int ret;



	if (!try_module_get(THIS_MODULE))

		return -EINVAL;



	pfile = kzalloc(sizeof(*pfile), GFP_KERNEL);

	if (!pfile) {

		ret = -ENOMEM;

		goto err_put_mod;

	}

	if (!pfile)

		return -ENOMEM;



	pfile->ptdev = ptdev;

	pfile->user_mmio.offset = DRM_PANTHOR_USER_MMIO_OFFSET;
@@ -1440,9 +1435,6 @@ panthor_open(struct drm_device *ddev, struct drm_file *file) 


err_free_file:

	kfree(pfile);



err_put_mod:

	module_put(THIS_MODULE);

	return ret;

}
@@ -1455,7 +1447,6 @@ panthor_postclose(struct drm_device *ddev, struct drm_file *file) 
	panthor_vm_pool_destroy(pfile);



	kfree(pfile);

	module_put(THIS_MODULE);

}



static const struct drm_ioctl_desc panthor_drm_driver_ioctls[] = {
@@ -1556,6 +1547,7 @@ static void panthor_show_fdinfo(struct drm_printer *p, struct drm_file *file) 
}



static const struct file_operations panthor_drm_driver_fops = {

	.owner = THIS_MODULE,

	.open = drm_open,

	.release = drm_release,

	.unlocked_ioctl = drm_ioctl,