Unverified Commit 7934fdc2 authored Sep 04, 2025 by Michal Wajdeczko Committed by Rodrigo Vivi Sep 09, 2025

drm/xe/configfs: Don't touch survivability_mode on fini



This is a user controlled configfs attribute, we should not
modify that outside the configfs attr.store() implementation.

Fixes: bc417e54 ("drm/xe: Enable configfs support for survivability mode")
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Riana Tauro <riana.tauro@intel.com>
Reviewed-by: Stuart Summers <stuart.summers@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20250904103521.7130-1-michal.wajdeczko@intel.com


(cherry picked from commit 079a5c83)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

parent 76eeb9b8

drivers/gpu/drm/xe/xe_survivability_mode.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -41,6 +41,8 @@
		*
		* # echo 1 > /sys/kernel/config/xe/0000:03:00.0/survivability_mode
		*
		* It is the responsibility of the user to clear the mode once firmware flash is complete.
		*
		* Refer :ref:`xe_configfs` for more details on how to use configfs
		*
		* Survivability mode is indicated by the below admin-only readable sysfs which provides additional
		@@ -147,7 +149,6 @@ static void xe_survivability_mode_fini(void *arg)
		struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
		struct device *dev = &pdev->dev;

		xe_configfs_clear_survivability_mode(pdev);
		sysfs_remove_file(&dev->kobj, &dev_attr_survivability_mode.attr);
		}