Commit 79492d5a authored by Ally Heev's avatar Ally Heev Committed by Herbert Xu
Browse files

crypto: asymmetric_keys - fix uninitialized pointers with free attribute 



Uninitialized pointers with `__free` attribute can cause undefined
behavior as the memory assigned randomly to the pointer is freed
automatically when the pointer goes out of scope.

crypto/asymmetric_keys doesn't have any bugs related to this as of now,
but, it is better to initialize and assign pointers with `__free`
attribute in one statement to ensure proper scope-based cleanup

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/


Signed-off-by: default avatarAlly Heev <allyheev@gmail.com>
Reviewed-by: default avatarIgnat Korchagin <ignat@cloudflare.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent a26c23e0

crypto/asymmetric_keys/x509_cert_parser.c

+1 −1
Original line number Diff line number Diff line
@@ -60,7 +60,7 @@ EXPORT_SYMBOL_GPL(x509_free_certificate); 
 */

struct x509_certificate *x509_cert_parse(const void *data, size_t datalen)

{

	struct x509_certificate *cert __free(x509_free_certificate);

	struct x509_certificate *cert __free(x509_free_certificate) = NULL;

	struct x509_parse_context *ctx __free(kfree) = NULL;

	struct asymmetric_key_id *kid;

	long ret;

crypto/asymmetric_keys/x509_public_key.c

+1 −1
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ int x509_check_for_self_signed(struct x509_certificate *cert) 
 */

static int x509_key_preparse(struct key_preparsed_payload *prep)

{

	struct x509_certificate *cert __free(x509_free_certificate);

	struct x509_certificate *cert __free(x509_free_certificate) = NULL;

	struct asymmetric_key_ids *kids __free(kfree) = NULL;

	char *p, *desc __free(kfree) = NULL;

	const char *q;