Commit 79765386 authored by Zhang Zekun's avatar Zhang Zekun Committed by Paolo Abeni
Browse files

net: ethernet: ibm: Simpify code with for_each_child_of_node() 



for_each_child_of_node can help to iterate through the device_node,
and we don't need to use while loop. No functional change with this
conversion.

Signed-off-by: default avatarZhang Zekun <zhangzekun11@huawei.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240816015837.109627-1-zhangzekun11@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 6b2efdc4

drivers/net/ethernet/ibm/ehea/ehea_main.c

+4 −6
Original line number Diff line number Diff line
@@ -3063,14 +3063,13 @@ static void ehea_shutdown_single_port(struct ehea_port *port) 
static int ehea_setup_ports(struct ehea_adapter *adapter)

{

	struct device_node *lhea_dn;

	struct device_node *eth_dn = NULL;

	struct device_node *eth_dn;



	const u32 *dn_log_port_id;

	int i = 0;



	lhea_dn = adapter->ofdev->dev.of_node;

	while ((eth_dn = of_get_next_child(lhea_dn, eth_dn))) {



	for_each_child_of_node(lhea_dn, eth_dn) {

		dn_log_port_id = of_get_property(eth_dn, "ibm,hea-port-no",

						 NULL);

		if (!dn_log_port_id) {
@@ -3102,12 +3101,11 @@ static struct device_node *ehea_get_eth_dn(struct ehea_adapter *adapter, 
					   u32 logical_port_id)

{

	struct device_node *lhea_dn;

	struct device_node *eth_dn = NULL;

	struct device_node *eth_dn;

	const u32 *dn_log_port_id;



	lhea_dn = adapter->ofdev->dev.of_node;

	while ((eth_dn = of_get_next_child(lhea_dn, eth_dn))) {



	for_each_child_of_node(lhea_dn, eth_dn) {

		dn_log_port_id = of_get_property(eth_dn, "ibm,hea-port-no",

						 NULL);

		if (dn_log_port_id)