Commit 798fa301 authored Feb 09, 2025 by Jonathan Cameron

iio: dac: ad3552r-hs: Stop using iio_device_claim_direct_scoped()



This complex cleanup.h use case of conditional guards has proved
to be more trouble that it is worth in terms of false positive compiler
warnings and hard to read code.

Move directly to the new claim/release_direct() that allow sparse
to check for unbalanced context.

Cc: Angelo Dureghello <adureghello@baylibre.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250209180624.701140-23-jic23@kernel.org


Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 5e802eed

drivers/iio/dac/ad3552r-hs.c

+9 −6

Original line number	Diff line number	Diff line
		@@ -129,16 +129,19 @@ static int ad3552r_hs_write_raw(struct iio_dev *indio_dev,
		int val, int val2, long mask)
		{
		struct ad3552r_hs_state *st = iio_priv(indio_dev);
		int ret;

		switch (mask) {
		case IIO_CHAN_INFO_RAW:
		if (!iio_device_claim_direct(indio_dev))
		return -EBUSY;
		/* For RAW accesses, stay always in simple-spi. */
		iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
		return st->data->bus_reg_write(st->back,
		ret = st->data->bus_reg_write(st->back,
		AD3552R_REG_ADDR_CH_DAC_16B(chan->channel),
		val, 2);
		}
		unreachable();

		iio_device_release_direct(indio_dev);
		return ret;
		default:
		return -EINVAL;
		}