Unverified Commit 79a6f2da authored by Haotian Zhang's avatar Haotian Zhang Committed by Mark Brown
Browse files

ASoC: mediatek: Fix double pm_runtime_disable in remove functions 



Both mt8195-afe-pcm and mt8365-afe-pcm drivers use devm_pm_runtime_enable()
in probe function, which automatically calls pm_runtime_disable() on device
removal via devres mechanism. However, the remove callbacks explicitly call
pm_runtime_disable() again, resulting in double pm_runtime_disable() calls.

Fix by removing the redundant pm_runtime_disable() calls from remove
functions, letting the devres framework handle it automatically.

Fixes: 2ca0ec01 ("ASoC: mediatek: mt8195-afe-pcm: Simplify runtime PM during probe")
Fixes: e1991d10 ("ASoC: mediatek: mt8365: Add the AFE driver support")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251020170440.585-1-vulab@iscas.ac.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6b03360f

sound/soc/mediatek/mt8195/mt8195-afe-pcm.c

+0 −1
Original line number Diff line number Diff line
@@ -3176,7 +3176,6 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev) 


static void mt8195_afe_pcm_dev_remove(struct platform_device *pdev)

{

	pm_runtime_disable(&pdev->dev);

	if (!pm_runtime_status_suspended(&pdev->dev))

		mt8195_afe_runtime_suspend(&pdev->dev);

}

sound/soc/mediatek/mt8365/mt8365-afe-pcm.c

+0 −1
Original line number Diff line number Diff line
@@ -2238,7 +2238,6 @@ static void mt8365_afe_pcm_dev_remove(struct platform_device *pdev) 


	mt8365_afe_disable_top_cg(afe, MT8365_TOP_CG_AFE);



	pm_runtime_disable(&pdev->dev);

	if (!pm_runtime_status_suspended(&pdev->dev))

		mt8365_afe_runtime_suspend(&pdev->dev);

}